chore(dogfooding devfiles): refresh dogfooding devfiles with the right memory usage, typescript plugin id, skip lint, format and test #1178
Conversation
…t memory usage, typescript plugin id, skip lint and test option.
sunix
requested review from
azatsarynnyy,
benoitf,
RomanNikitenko and
vzhukovs
as code owners
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
sunix
changed the title
|
FYI I can build and run che-theia with |
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
|
|
OK Maybe we have to ajust the memory usage of our plugins ... for instance, machine-exec |
|
It would be nice to rename |
| env: | ||
| - name: BUILD_PATH | ||
| value: /tmp | ||
|
|
||
| commands: | ||
|
|
||
| - name: set theia to the pinned revision |
There was a problem hiding this comment.
Let's name it 1. Set theia to the pinned revision and shift index of other commands. Just to be consistent with other command and keep the order of commands.
There was a problem hiding this comment.
Is it better to use git checkout ${THEIA_COMMIT_SHA} ??
git reset don't switch to the commit on my side. I just opened a terminal and used git status to check.
There was a problem hiding this comment.
it does: check where your local master is pointing to git log
There was a problem hiding this comment.
${THEIA_COMMIT_SHA} is not a branch btw
There was a problem hiding this comment.
We use git checkout when building the images
https://github.com/eclipse-che/che-theia/blob/main/dockerfiles/theia/docker/alpine/builder-clone-theia.dockerfile#L3
Let's use the same command.
There was a problem hiding this comment.
ok but a dev environment is different from a build environment. If you do any changes in theia, what would be the branch used by default. it should be master by default so git reset --hard is to be used.
There was a problem hiding this comment.
Anyway it looks much better if git status says me where I am, e.g.
$ git status
HEAD detached at 4a627bb
It looks nice as well if I changed some files
$ git status
HEAD detached at 4a627bb
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: devfile.yaml
no changes added to commit (use "git add" and/or "git commit -a")
|
@vitaliy-guliy i renamed the files and commands |
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Codecov Report
@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
- Coverage 32.78% 32.67% -0.11%
==========================================
Files 290 290
Lines 9885 9927 +42
Branches 1457 1463 +6
==========================================
+ Hits 3241 3244 +3
- Misses 6641 6680 +39
Partials 3 3
Continue to review full report at Codecov.
|
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
What does this PR do?
Refreshing dogfooding devfiles
Screenshot/screencast of this PR
What issues does this PR fix or reference?
making the dogfooding devfiles working before merging them in the root one: eclipse-che/che#18763
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable