This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Add missing dependencies for task plugin #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
benoitf
reviewed
Mar 26, 2019
|
thank you, Yevhen! |
RomanNikitenko
approved these changes
Mar 26, 2019
Signed-off-by: Yevhen Vydolob <[email protected]>
|
@RomanNikitenko You need to create CQ for |
|
FYI you may use reflect-metadata 0.1.8 https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12001 already approved and piggy back https://dev.eclipse.org/ipzilla/show_bug.cgi?id=17257 (inversify 4.13.0) to speed up the process |
|
I am going to test my changes for "inversify": "4.14.0" and "reflect-metadata": "0.1.10" and create CQ |
|
To speed up the process I tested it for "inversify": "4.13.0" and "reflect-metadata": "0.1.8" - it works fine for me. |
Signed-off-by: Roman Nikitenko <[email protected]>
benoitf
approved these changes
Mar 26, 2019
|
The Piggyback for "inversify": "4.13.0" https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19424 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yevhen Vydolob [email protected]