Simplify and parametrize setting terminal type.

eclipse-che · Feb 5, 2020 · 1d9b28e · 1d9b28e
1 parent 36ee63c
commit 1d9b28e
Showing 1 changed file with 5 additions and 16 deletions.
diff --git a/tests/e2e/utils/PreferencesHandler.ts b/tests/e2e/utils/PreferencesHandler.ts
@@ -12,24 +12,13 @@ export class PreferencesHandler {
     constructor(@inject(CLASSES.RequestHandler) private readonly requestHandler: RequestHandler) {
     }
 
-    public async setTerminalToDom() {
+    public async setTerminalType(type: string) {
         Logger.debug('PreferencesHandler.setTerminalToDom');
         const response = await this.requestHandler.processRequest(RequestType.GET, `${TestConstants.TS_SELENIUM_BASE_URL}/api/preferences`);
         let userPref = response.data;
-        try {
-            let theiaPref = JSON.parse(userPref['theia-user-preferences']);
-            let terminal = theiaPref['terminal.integrated.rendererType'];
-            if ( terminal === 'dom' ) {
-                Logger.trace('Terminal renderer type already set to dom.');
-            } else {
-                Logger.trace('Setting terminal renderer type to dom.');
-                theiaPref['terminal.integrated.rendererType'] = 'dom';
-                userPref['theia-user-preferences'] = JSON.stringify(theiaPref);
-                this.requestHandler.processRequest(RequestType.POST, `${TestConstants.TS_SELENIUM_BASE_URL}/api/preferences`, userPref);
-            }
-        } catch (e) {
-            Logger.trace('Can not set terminal renderer type.');
-            throw e;
-        }
+        let theiaPref = JSON.parse(userPref['theia-user-preferences']);
+        theiaPref['terminal.integrated.rendererType'] = type;
+        userPref['theia-user-preferences'] = JSON.stringify(theiaPref);
+        this.requestHandler.processRequest(RequestType.POST, `${TestConstants.TS_SELENIUM_BASE_URL}/api/preferences`, userPref);
     }
 }