Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Callers of org.eclipse.jdt.ls.core.internal.JDTUtils.toLocation(IJavaElement) #10874

Closed
tsmaeder opened this issue Aug 22, 2018 · 1 comment
Closed

Review Callers of org.eclipse.jdt.ls.core.internal.JDTUtils.toLocation(IJavaElement) #10874

tsmaeder opened this issue Aug 22, 2018 · 1 comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current target/branch Indicates that a PR will be merged into a branch other than master.

Comments

@tsmaeder
Copy link
Contributor

We have come across a NPE in a selenium test where the result of org.eclipse.jdt.ls.core.internal.JDTUtils.toLocation(IJavaElement) was used without handling the null case. We should check all call sites of this method to see if null is handled.
@tsmaeder tsmaeder added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current target/branch Indicates that a PR will be merged into a branch other than master. team/languages labels Aug 22, 2018
@tsmaeder tsmaeder mentioned this issue Aug 22, 2018
Closed
@svor svor mentioned this issue Aug 27, 2018
Merged
@sunix
Copy link
Contributor

sunix commented Jul 4, 2019

Looks like fixed

@sunix sunix closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunix @tsmaeder