This repository has been archived by the owner on Mar 23, 2022. It is now read-only.
Fix NPE in FindImplementersHandler #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
approved these changes
Aug 27, 2018
| offset = nameRange.getOffset(); | ||
| length = nameRange.getLength(); | ||
| } | ||
| if (cf == null) { |
There was a problem hiding this comment.
"if (unit != null) {" would be clearer.
| @@ -85,6 +94,55 @@ static SymbolKind mapKind(IJavaElement element) { | |||
| return DocumentSymbolHandler.mapKind(element); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Why move this here? It's only ever used in FindImplementersHandler.
There was a problem hiding this comment.
It will be useful to solve: eclipse-che/che#10874
| } | ||
| } | ||
|
|
||
| @SuppressWarnings("restriction") | ||
| private static SymbolInformation convertToSymbolInformation(IJavaElement javaElement) | ||
| throws JavaModelException { | ||
| private static SymbolInformation convertToSymbolInformation( |
There was a problem hiding this comment.
If I understand it correctly, both call sites us the same method to compute the location. Why not just move it inside the "convertToSymbolInformation" method?
Signed-off-by: Valeriy Svydenko <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Valeriy Svydenko [email protected]
Sets source range with values: length == 0 and offset == 0 if it is not possible to calculate for source member.
Related issue: eclipse-che/che#10857