Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Che-theia - My workspace view: if available, show the che commands/task that are available in a plugin side car #13587

Closed
sunix opened this issue Jun 17, 2019 · 8 comments · Fixed by eclipse-che/che-theia#496
Closed

Che-theia - My workspace view: if available, show the che commands/task that are available in a plugin side car #13587

sunix opened this issue Jun 17, 2019 · 8 comments · Fixed by eclipse-che/che-theia#496
Assignees
@mmorhun
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template.
Milestone
7.3.0

Comments

@sunix
Copy link
Contributor

sunix commented Jun 17, 2019

Description

If the devfile has commands defined for a plugin side car, it make sense to display them by default in the my workspace view

either:

  • expand plugins if some che commands (task) available inside a plugin sidecar
  • display a plugin side car with checommands ... inside the user runtimes

Selection_301
@sunix sunix transferred this issue from eclipse-che/che-theia Jun 20, 2019
@sunix sunix changed the title My workspace view: if available, show the che commands/task that are available in a plugin side car Che-theia - My workspace view: if available, show the che commands/task that are available in a plugin side car Jun 20, 2019
@slemeur slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 20, 2019
@sunix
Copy link
Contributor Author

sunix commented Jul 23, 2019

@l0rd @slemeur @tsmaeder @rhopp @nickboldt could we priotize that one ?

@slemeur slemeur modified the milestone: 7.1.0 Jul 23, 2019
@slemeur
Copy link
Contributor

slemeur commented Jul 23, 2019

+1 for 7.1.0 for me

@nickboldt nickboldt added this to the 7.1.0 milestone Jul 23, 2019
@nickboldt
Copy link
Contributor

Sure, 7.1

@slemeur slemeur added team/ide2 area/editor/theia Issues related to the che-theia IDE of Che labels Jul 26, 2019
@slemeur
Copy link
Contributor

slemeur commented Aug 2, 2019

Do you have an example plugin and how it would look in the devfile @sunix ?

@slemeur slemeur modified the milestones: 7.1.0, 7.3.0 Aug 2, 2019
@sunix
Copy link
Contributor Author

sunix commented Aug 7, 2019 •
edited
Loading

@slemeur I was thinking that we would not change anything in the devfile

I was more thinking, by default in the workspace view, expanding all the container items that contains commands and collapse all the containers that doesn't contain any commands. whether these containers are user containers or plugin containers.

@slemeur
Copy link
Contributor

slemeur commented Aug 8, 2019

ok pure UI/ux improvement

This was referenced Sep 17, 2019
Closed
Closed
@evidolob evidolob mentioned this issue Oct 9, 2019
Closed
13 tasks
@mmorhun mmorhun self-assigned this Oct 17, 2019
@mmorhun mmorhun mentioned this issue Oct 17, 2019
Merged
@mmorhun
Copy link
Contributor

mmorhun commented Oct 17, 2019

Done

@sunix
Copy link
Contributor Author

sunix commented Oct 18, 2019

@mmorhun so this is not doing what I had suggested in #13587 (comment)

@mmorhun mmorhun mentioned this issue Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorhun mmorhun

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.3.0
Development

Successfully merging a pull request may close this issue.

Unfold Plugins section if a plugin container has a command eclipse-che/che-theia
4 participants
@nickboldt @sunix @slemeur @mmorhun