Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for testing of parallel plugin/sidecar update PRs #18806

Closed
tsmaeder opened this issue Jan 14, 2021 · 3 comments
Closed

Allow for testing of parallel plugin/sidecar update PRs #18806

tsmaeder opened this issue Jan 14, 2021 · 3 comments
Labels
area/plugin-registry area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@tsmaeder
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

When the update of a vscode extensions in a plugin requires an updated sidecar (eclipse-che/che-plugin-registry#794, for example), there is no easy way to test that combination: the plugin registry built as part of the PR check references an image that does not exist, in this case.
The current solution is to update the sidecar first and then update the plugin in a separate PR. However, in the case of the mentioned PR, the updated sidecar does not work with the old extension, thus, we would have a time window where workspaces using the updated sidecar would fail.

Describe the solution you'd like

I would updated like to be able to test the PR with changes to both the sidecar and plugin. Merging should promote both changes simultaneously to "production".

Describe alternatives you've considered

Additional context

@tsmaeder tsmaeder added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 14, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 14, 2021
@rhopp rhopp added area/plugins severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 14, 2021
@ericwill ericwill changed the title Allow for parallel updates of plugins and sidecars Allow for testing of parallel plugin/sidecar update PRs Feb 3, 2021
@ericwill
Copy link
Contributor

This actually used to work, before we started checking sidecar validity in the plugin registry build process. Since we turned that on, updates to both sidecars and plugins in the same PR will fail, because the tag is based on the SHA1 of the change: eclipse-che/che-plugin-registry#848 (comment)

A few options:

  • we could build and push the sidecar tag during the sidecar PR build, but this would require the plugin build depending on the sidecar build/push to finish.
  • we could skip checking of images if the SHA1 ID in the PR matches the tag being checked

cc @benoitf

@benoitf
Copy link
Contributor

benoitf commented Feb 22, 2021

There are pros and cons on both sides. If we skip it means published version on surge is also unsuitable.
And we can't publish from forked repositories due to token issues so difficult to say.
Should we just abort and say side-cars need to be updated first ( nicer error message than today)

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2021
@che-bot che-bot closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants