Update vale to "official" version 0.12.0 #794
Conversation
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
requested review from
benoitf,
ericwill,
sunix,
svor,
vinokurig and
vitaliy-guliy
as code owners
| FROM alpine:3.12.1 | ||
|
|
||
| ENV HOME=/home/theia | ||
| ENV VALE_VERSION=2.4.0 | ||
|
|
||
| COPY --from=vale /bin/vale /usr/local/bin |
There was a problem hiding this comment.
hello, why do we copy from a docker image the binary instead of the release as before ?
(because docker.io has limits so it might be an issue to use it)
There was a problem hiding this comment.
because the published binaries don't run on alpine. Using ldd, you can see that they are dynlinked to libc.
che-theia-plugins.yaml
Outdated
| url: https://github.com/testthedocs/vscode-vale | ||
| revision: 0.9.1 | ||
| url: https://github.com/errata-ai/vale-vscode/ | ||
| revision: 0.12.0 |
There was a problem hiding this comment.
A few things:
- The latest version is 0.14.2, not 0.12.0: https://github.com/errata-ai/vale-vscode/releases
- The revision field must match a valid tag/branch/SHA1 from the repository, which in this case would be
v0.12.0, orv0.14.2if we go with 0.14.2.
There was a problem hiding this comment.
Why would that matter? The vsix is from open-vsx, not built.
There was a problem hiding this comment.
Also: the latest version published to open-vsx is 0.12. Since we can't use the marketplace 🤷
There was a problem hiding this comment.
There was a problem hiding this comment.
The revision field must match a valid tag/branch/SHA1 from the repository, which in this case would be v0.12.0, or v0.14.2 if we go with 0.14.2.
@ericwill the CI job is not checking that revision is valid ?
@tsmaeder AFAIK this field is used by the plug-in 'automatic-check' that generates report https://eclipse.github.io/che-plugin-registry/
There was a problem hiding this comment.
The revision field must match a valid tag/branch/SHA1 from the repository, which in this case would be v0.12.0, or v0.14.2 if we go with 0.14.2.
@ericwill the CI job is not checking that revision is valid ?
It was for the old vscode-extensions.json file, it has not yet been ported to the new che-theia-plugins.yaml system. It's on the radar for next sprint: eclipse-che/che#18729
| @@ -8,19 +8,20 @@ | |||
| # Contributors: | |||
There was a problem hiding this comment.
We should probably update the copyright header to 2021.
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder [email protected]
What does this PR do?
Updates vale sidecar to 2.8.0 and extensions to the one from "errata.ai" v 0.12.0
What issues does this PR fix or reference?
eclipse-che/che#18755
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.