Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'warning' state for the notifications. #3029

Closed
xcoulon opened this issue Nov 9, 2016 · 1 comment
Closed

Add a 'warning' state for the notifications. #3029

xcoulon opened this issue Nov 9, 2016 · 1 comment
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/in-progress This issue has been taken by an engineer and is under active development.

Comments

@xcoulon
Copy link
Contributor

xcoulon commented Nov 9, 2016

In Che, the notification manager can display messages in small, floating toasts on top of the editors or in the event bar at the bottom of the IDE. The NotificationManager is responsible for displaying these messages along with a status, defined by the org.eclipse.che.ide.api.notification.StatusNotification.Status enumeration.

In its current state, the enumeration provides with the following values:

  • PROGRESS
  • SUCCESS
  • FAIL

Hélas, this does not fully match with the types of message defined in the Language Server Protocol where the types are:

  • Error
  • Warning
  • Info
  • Log

While it is possible to bind the Info and Log message types to the SUCCESS notification status, and the Error message type to the FAIL notification status, there remain a gap for the Warning message type.

This is issue is thus about adding a new value in the org.eclipse.che.ide.api.notification.StatusNotification.Status enumeration along with a triangle icon in the UI using the #F8E71C color.

Che version: 5.0.0-M7

Additional information:
Linked issue: #1793

@benoitf benoitf added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Nov 9, 2016
@xcoulon
Copy link
Contributor Author

xcoulon commented Nov 17, 2016

Pull request submitted: #3113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

3 participants