Issue 3029 - Add a 'warning' state for the notifications #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `#F0AD4E` code for the darkish orange background, so the font can remain white and be consistent with other types of notifications Signed-off-by: Xavier Coulon <[email protected]>
|
Can one of the admins verify this patch? |
slemeur
added
the
kind/enhancement
|
Thanks @xcoulon ! Please @ashumilova , @vzhukovskii + @vitaliy-guliy could you review? |
|
+1 |
vzhukovs
approved these changes
Nov 18, 2016
|
ci-build |
vitaliy-guliy
approved these changes
Nov 18, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1065/ |
benoitf
approved these changes
Nov 18, 2016
|
thanks ! |
vparfonov
pushed a commit
that referenced
this pull request
Dec 5, 2016
#3124) Added a ShowMessageProcessor and a ShowMessageMessager classes to process incoming `window/showMessage` notification and display a notification in `float` mode in the UI if the message type is `error` or `warning`, in the events panel otherwise. Note that the notification type for `error` messages is incorrectly set to `Log` because of a bug in the typefox dependency: `io.typefox.lsapi.MessageType#Log` has the value `1` instead of `4`. This issue depends on #3113 (Add a 'warning' state for the notifications) To test the pull request, please follow the instructions on #3123 to run the 'test-lang' server. Once in the workspace, create a project, add a `foo.test` file (the Language Server support for the 'test-lang' will be activated), then type the following line > window/showMessage:error: a message and wait for the editor to save the changes. This will trigger a `window/showMessage` notification from the 'test-lang' server in the Che UI. Signed-off-by: Xavier Coulon <[email protected]>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…#3113) Using the `#F0AD4E` code for the darkish orange background, so the font can remain white and be consistent with other types of notifications Signed-off-by: Xavier Coulon <[email protected]>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
eclipse-che#3124) Added a ShowMessageProcessor and a ShowMessageMessager classes to process incoming `window/showMessage` notification and display a notification in `float` mode in the UI if the message type is `error` or `warning`, in the events panel otherwise. Note that the notification type for `error` messages is incorrectly set to `Log` because of a bug in the typefox dependency: `io.typefox.lsapi.MessageType#Log` has the value `1` instead of `4`. This issue depends on eclipse-che#3113 (Add a 'warning' state for the notifications) To test the pull request, please follow the instructions on eclipse-che#3123 to run the 'test-lang' server. Once in the workspace, create a project, add a `foo.test` file (the Language Server support for the 'test-lang' will be activated), then type the following line > window/showMessage:error: a message and wait for the editor to save the changes. This will trigger a `window/showMessage` notification from the 'test-lang' server in the Che UI. Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Previous behavior
(Remove this section if not relevant)
New behavior
(Explain the PR as it should appear in the release notes)
Please review Che's Contributing Guide for best practices.
Using the
#F0AD4Ecode for the darkish orange background, so thefont can remain white and be consistent with other types of notifications
Signed-off-by: Xavier Coulon [email protected]