Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI che-cli dockerimage build failed #3980

Closed
riuvshin opened this issue Feb 1, 2017 · 1 comment
Closed

CLI che-cli dockerimage build failed #3980

riuvshin opened this issue Feb 1, 2017 · 1 comment
Assignees
@benoitf
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@riuvshin
Copy link
Contributor

riuvshin commented Feb 1, 2017

Im not able to build che-cli image with tests

No tag provided, using nightly as default
Building Docker Image eclipse/che-cli from /Users/roman/development/codenvy_projects/che/dockerfiles/cli directory with tag nightly
Sending build context to Docker daemon 54.78 kB
Step 1/5 : FROM eclipse/che-base:nightly
nightly: Pulling from eclipse/che-base
b7f33cc0b48e: Already exists
949adc96e811: Already exists
b475c3c29375: Already exists
Digest: sha256:a07a9f1a11f20e5a766271df2cc993ab7d032de6b9b391bf6b5939deef755bf6
Status: Downloaded newer image for eclipse/che-base:nightly
 ---> 95c73fa14e23
Step 2/5 : COPY scripts /scripts/
 ---> 9d6ea5566511
Removing intermediate container 05ad31a5572b
Step 3/5 : COPY version /version/
 ---> 29eb9cb8ee18
Removing intermediate container 6258a0e60add
Step 4/5 : RUN mkdir /che && chmod u+x /scripts/entrypoint.sh
 ---> Running in 03d0adc7ca52
 ---> afb8598ab7cf
Removing intermediate container 03d0adc7ca52
Step 5/5 : ENTRYPOINT /scripts/entrypoint.sh
 ---> Running in 194ca664f3f7
 ---> 43b54f1a5a88
Removing intermediate container 194ca664f3f7
Successfully built 43b54f1a5a88
Script run successfully: eclipse/che-cli:nightly
Running tests in container from image eclipse/che-bats:nightly
Running functional bats tests for CLI prompts and usage
Running functional bats tests for init and destroy commands
Running functionals bats tests for start command

[11:10:40]roman:cli[master]#: echo $?
1
@riuvshin riuvshin added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 1, 2017
@riuvshin riuvshin added this to the 5.2.0 milestone Feb 1, 2017
@riuvshin riuvshin added the severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. label Feb 1, 2017
@riuvshin riuvshin removed this from the 5.2.0 milestone Feb 1, 2017
@riuvshin riuvshin added severity/P1 Has a major impact to usage or development of the system. and removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Feb 1, 2017
@riuvshin
Copy link
Contributor Author

riuvshin commented Feb 1, 2017

drop milestone as I can release with skipping tests, but it is still p1 issue

@benoitf benoitf self-assigned this Feb 1, 2017
benoitf added a commit that referenced this issue Feb 1, 2017
@benoitf
Fix #3980 by reworking how integration tests are launched
77e8748 
- We used OS path mounted into container path (it makes issues as on Windows we don’t have these paths)
- Now use /dockerfiles path inside the container
- add skip check for nightlies or it was downloading new images while testing the current nightly
- add —rm for cleaning containers at the end of the start
- introduce of some asserts instead of custom checks

Change-Id: I352d7c475796df641c1e34f461c55a76c897922d
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf mentioned this issue Feb 1, 2017
Merged
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 1, 2017
@benoitf benoitf added this to the 5.3.0 milestone Feb 1, 2017
@benoitf benoitf closed this as completed in 5554345 Feb 2, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 2, 2017
@JamesDrummond JamesDrummond removed this from the 5.3.0 milestone Feb 17, 2017
JPinkney pushed a commit to JPinkney/che that referenced this issue Aug 17, 2017
@benoitf
[cli] Fix cli tests by reworking how integration tests are launched (e…
ca74467 
…clipse-che#3991)

* Fix eclipse-che#3980 by reworking how integration tests are launched
- We used OS path mounted into container path (it makes issues as on Windows we don’t have these paths)
- Now use /dockerfiles path inside the container
- add skip check for nightlies or it was downloading new images while testing the current nightly
- add —rm for cleaning containers at the end of docker run
- introduce of some asserts instead of custom checks
- Fix windows issue (like path with spaces)
- Fix teardown of che start tests

Change-Id: I352d7c475796df641c1e34f461c55a76c897922d
Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benoitf @riuvshin @JamesDrummond