Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework workspace key to new format where namespace can contain / symbols #4061

Closed
sleshchenko opened this issue Feb 8, 2017 · 0 comments
Closed

Rework workspace key to new format where namespace can contain / symbols #4061

sleshchenko opened this issue Feb 8, 2017 · 0 comments
Assignees
@sleshchenko
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@sleshchenko
Copy link
Member

Rework workspace key to new format where namespace can contain / symbols.
Now workspace key have following format:

  • {workspaceId}
  • {namespace}:{workspaceName}
  • :{workspaceName}

It is needed to rework workspace key to have following format:

  • {workspaceId}
  • {namespace}/{workspaceName}
    Note that namespace can contains / so workspace key can looks like {namespace_part1}/{namespace_part2}/.../{namespace_partN}/{workspaceName}.
@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/plugin labels Feb 8, 2017
@sleshchenko sleshchenko self-assigned this Feb 8, 2017
@sleshchenko sleshchenko mentioned this issue Feb 8, 2017
Closed
@sleshchenko sleshchenko mentioned this issue Feb 9, 2017
Merged
@sleshchenko sleshchenko added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. status/in-progress This issue has been taken by an engineer and is under active development. labels Feb 9, 2017
@sleshchenko sleshchenko added this to the 5.3.0 milestone Feb 10, 2017
@ashumilova ashumilova mentioned this issue Feb 12, 2017
Closed
benoitf added a commit that referenced this issue Feb 13, 2017
@benoitf
Make backward compliance for the workspace keys with ":" and optional…
9bf41b1 
… namespace value

Broken by #4061

Change-Id: I884e8adef2f01774f00a9f6c08ca834fc22b5917
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf mentioned this issue Feb 13, 2017
Merged
benoitf added a commit that referenced this issue Feb 15, 2017
@benoitf
fixup! Make backward compliance for the workspace keys with ":" and o…
07cd05d 
…ptional namespace value Broken by #4061
benoitf added a commit that referenced this issue Feb 15, 2017
@benoitf
fixup! Make backward compliance for the workspace keys with ":" and o…
dd0425a 
…ptional namespace value Broken by #4061
benoitf added a commit that referenced this issue Feb 15, 2017
@benoitf
Make backward compliance for the workspace keys with ":" and optional…
a1d230c 
… namespace value (#4123)

* Make backward compliance for the workspace keys with ":" and optional namespace value
Broken by #4061
This backward compliance will be soon removed once deprecation time is over
Change-Id: I884e8adef2f01774f00a9f6c08ca834fc22b5917
Signed-off-by: Florent BENOIT <[email protected]>
@JamesDrummond JamesDrummond removed this from the 5.3.0 milestone Feb 17, 2017
JPinkney pushed a commit to JPinkney/che that referenced this issue Aug 17, 2017
@benoitf
Make backward compliance for the workspace keys with ":" and optional…
9d20e66 
… namespace value (eclipse-che#4123)

* Make backward compliance for the workspace keys with ":" and optional namespace value
Broken by eclipse-che#4061
This backward compliance will be soon removed once deprecation time is over
Change-Id: I884e8adef2f01774f00a9f6c08ca834fc22b5917
Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleshchenko sleshchenko

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashumilova @sleshchenko @JamesDrummond