Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Eclipse Dependencies #10906

Closed
wants to merge 156 commits into from
Closed

Remove Eclipse Dependencies #10906

wants to merge 156 commits into from

Conversation

tsmaeder
Copy link
Contributor

What does this PR do?

Removes unused dependencies on Eclipse bundles and fixes some leftover usages.
Related PR's
*
*

What issues does this PR fix or reference?

Clean Up Java/Maven Leftovers #10872

tsmaeder added 30 commits August 22, 2018 11:45
@tsmaeder
Adapt json->java
84e45cc 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Clean up install script & added launcher plugin
71a0860
@tsmaeder
Add meaningful data dir
ab7623d 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Set current dir when starting jdt.ls
e199a3f
@tsmaeder
Turn off Java editor
0df80c3
@tsmaeder
Make sure boolean values are set (be forgiving of bogus LSs)
e2bd94c
@tsmaeder
License header, formatting
0eaaf03
@tsmaeder
Fix up command id for jdt.ls code actions
e44e16f
@tsmaeder
First cut of opening references in jars
a88c8a8
@tsmaeder
Update to latest che version
7f54d28 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Makes support for class file contents work
ec7a35c 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Update to 5.19.0
420df2f 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Use one language server per workspace
1714be1 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Fix blocked IllegalStateException on LS startup
fbfff0d 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Add rangeLength field to didChange notification
707f91a 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Log jdt.ls status messages to log.
e774908
@tsmaeder
Use LSP editor for maven and class files.
ca24761
@tsmaeder
Register file watches for Java
5e5d51d 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Added shutdown/exit handling
5059cf4 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Set mime type to get syntax coloring
4857d3c 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Fix selection when opening references
4a3f91a 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Fix import order
0630314 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Use LSP editor even if no capabilities are found.
7c61d8e 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Start language server for watched file patterns
cfc6f37 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Licenses, formatting, dependencies
7b41180 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Port to Che 6
5df4df9 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Introduce LaunchingStrategy to allow per project/workspace LS's
c3b45b9 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Use LaunchingStrategy in Java LS.
aeefc99 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Log telemetry in debug only to reduce load,
c2c4bcf 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Use {} format for log messages
ac1fb86 
Signed-off-by: Thomas Mäder <[email protected]>
Valeriy Svydenko and others added 19 commits August 22, 2018 12:19
@tsmaeder
Fix for checking Java Compiler settings in selenium test (eclipse-che…
72f6db3 
…#10623)

Signed-off-by: Valeriy Svydenko <[email protected]>
@tsmaeder
Update generated effective pom (eclipse-che#10635)
981f270 
Signed-off-by: Valeriy Svydenko <[email protected]>
@tsmaeder
Handle markdown in LSP doc popups (eclipse-che#10645)
e2d548c 
* Use Orion's "marked" to support markdown in doc popups

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Moved class comment (eclipse-che#10655)
36ae15e 
Signed-off-by: Thomas Mäder <[email protected]>
@tolusha @tsmaeder
Merging master
60e145d 
Signed-off-by: Anatoliy Bazko <[email protected]>
@tolusha @tsmaeder
Update project config when event is fired (eclipse-che#10677)
6ce2fd8 
* Update project config when event is fired

Signed-off-by: Anatoliy Bazko <[email protected]>
@vrubezhny @tsmaeder
New folders do not register in the jdt.ls workspace eclipse-che#10115 (…
6014a9b 
…eclipse-che#10665)

Signed-off-by: Victor Rubezhny <[email protected]>
@tsmaeder
Update maven module if parent was changed (eclipse-che#10689)
5ee09b7
@tsmaeder
Don't write to test codebase (eclipse-che#10765)
4855d2f 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Update copyright in test to epl 2.0 (eclipse-che#10773)
4216139 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Fix parent path handling when importing test projects (eclipse-che#10785
f3e607b 
)

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Fix resource leak in ZipUtils (eclipse-che#10815)
9f72440 
Signed-off-by: Thomas Mäder <[email protected]>
@tolusha @tsmaeder
Get rid of redundant dependency (eclipse-che#10835)
01768ca 
Signed-off-by: Anatoliy Bazko <[email protected]>
@tsmaeder
Wait when JDT.LS is started (eclipse-che#10847)
2181fa8 
Signed-off-by: Valeriy Svydenko <[email protected]>
@tsmaeder
Adapt tests to correct observed behaviour (eclipse-che#10824)
a2b2c7f 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Re-Remove Maven server
f025c76 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Update version 6.11.0-SNAPSHOT
f85d8dc 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Fix formatting post-rebase
77183f8 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Removed unused eclipse bundles
e8c55ff 
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder added kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master. team/languages labels Aug 24, 2018
@tsmaeder tsmaeder requested review from vparfonov and tolusha August 24, 2018 13:01
@tsmaeder tsmaeder closed this Aug 24, 2018
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov Awaiting requested review from vparfonov

@tolusha tolusha Awaiting requested review from tolusha

@ashumilova ashumilova Awaiting requested review from ashumilova

@dkulieshov dkulieshov Awaiting requested review from dkulieshov

@riuvshin riuvshin Awaiting requested review from riuvshin

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tsmaeder @benoitf @svor @mmorhun @tolusha @bdshadow @vinokurig @JPinkney @vrubezhny