Fix for RunPlainJavaProjectTest test #11133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svor
added
kind/bug
svor
requested review from
dmytro-ndp,
musienko-maxim,
Ohrimenko1988 and
vparfonov
as code owners
tolusha
approved these changes
Sep 10, 2018
tsmaeder
requested changes
Sep 11, 2018
...-selenium-test/src/test/java/org/eclipse/che/selenium/plainjava/RunPlainJavaProjectTest.java
Show resolved
Hide resolved
| .get(wsPath) | ||
| .orElseThrow(() -> new ServerException("Can't find a project: " + wsPath)); | ||
|
|
||
| List<String> library = project.getAttributes().get(LIBRARY_FOLDER); |
There was a problem hiding this comment.
If this property is set, shouldn't the classpath have been updated before? I'm not sure why we need this code.
There was a problem hiding this comment.
This code executes when the property was set and if this property exists we need to update classpath to add jars from this folder.
| @@ -84,16 +87,24 @@ public JavaLanguageServerLauncher( | |||
| this.notifyTransmitter = notifyTransmitter; | |||
| this.eventService = eventService; | |||
| this.projectManager = projectManager; | |||
|
|
|||
| isStarted = new AtomicBoolean(); | |||
There was a problem hiding this comment.
Please use AtomicBoolean(false). While I would expect the default value to be false, I have to check the javadoc on AtomicBoolean to be sure.
tsmaeder
force-pushed
the
5730_java_ls_poc
branch
from
db8cb38 to
11e5b10
Compare
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
|
@tsmaeder PR was updated |
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
approved these changes
Sep 14, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Sep 14, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
benoitf
removed
the
status/code-review
tsmaeder
pushed a commit
that referenced
this pull request
Sep 20, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 26, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Valeriy Svydenko [email protected]
What does this PR do?
Make it possible to configure folder with libraries for plain java project
What issues does this PR fix or reference?
#11110
Release Notes
Docs PR