Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce devfile docs build & deploy script #12646

Merged
merged 28 commits into from
Feb 11, 2019
Merged

Introduce devfile docs build & deploy script #12646

merged 28 commits into from
Feb 11, 2019

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Feb 11, 2019 •
edited
Loading

What does this PR do?

Introduces devfile docs build & deploy script.

  • Docs can be build in both native and docker mode (using --docker switch).
  • Script requires DEVFILE_DOCS_GITHUB_TOKEN to be set to clone/push docs repo.
  • Commit message can be specified with --message parameter
  • Deploy can be skipped with --no-deploy parameter

What issues does this PR fix or reference?

#12524

Release Notes

N/A

Docs PR

N/A

@mshaposhnik
Add build of docs from json schema
4f27f28 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Merge branch 'master' into docs_build
a05726e 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fixes in docs build
c89cf5f 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Merge branch 'master' into docs_build
3c0daac 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Minor fixups
608a286 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Cleanup
fd1f563 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Cleanup
a385cc5 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fixup! Cleanup
b4c13b5 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Fixup formatting
949c25b 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Fixup dockerfile
304115f 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
build with script
62f8a0f 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
remove profiles
affba4f 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fix license
56dbb7b 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Exclude resources from packaging
4dc9c06 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Use tmp folder for all op-s
44f4fcd 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fixup! Use tmp folder for all op-s
e885b6e 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Fix tmp
f046965 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fixup! Fix tmp
e2a8368 
Signed-off-by: Max Shaposhnik <[email protected]>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Feb 11, 2019
@mshaposhnik
fixup! fixup! Fix tmp
e5a618b 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fixup! fixup! fixup! Fix tmp
df6d997 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fixup! fixup! fixup! fixup! Fix tmp
3685ac4 
Signed-off-by: Max Shaposhnik <[email protected]>
riuvshin
riuvshin approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@riuvshin riuvshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mshaposhnik
Script fixups
4b14316 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Fixups
d6cc5e2 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Rename param
067406b 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Rename variables
c4cfce9 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
Use tag in docker build
9bae109 
Signed-off-by: Max Shaposhnik <[email protected]>
sleshchenko
sleshchenko approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be so nice to have --help argument which would print short information about script, possible arguments and example of usage.

@mshaposhnik
Add help command
e658c24 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik
fixup! Add help command
a759e2b 
Signed-off-by: Max Shaposhnik <[email protected]>
@mshaposhnik mshaposhnik merged commit c6d1466 into master Feb 11, 2019
@mshaposhnik mshaposhnik deleted the docs_build_script branch February 11, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@riuvshin riuvshin riuvshin approved these changes

@mkuznyetsov mkuznyetsov Awaiting requested review from mkuznyetsov

@metlos metlos Awaiting requested review from metlos

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mshaposhnik @skabashnyuk @riuvshin @sleshchenko @che-bot