Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more informative error message #12814

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Provide more informative error message #12814

merged 3 commits into from
Mar 4, 2019

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Provide more informative error message in case of execution rejection on major websocket endpoint of JSON RPC stack

Follow up of #12673 (comment)

What issues does this PR fix or reference?

#12673 (comment)

Release Notes

n/a

Docs PR

n/a

@skabashnyuk
Provide more informative error message in case of rejection on major …
16e284a 
…websocket endpoint of JSON RPC stack

Signed-off-by: Sergii Kabashniuk <[email protected]>
@skabashnyuk skabashnyuk requested a review from riuvshin as a code owner March 2, 2019 22:00
@skabashnyuk
Copy link
Contributor Author

skabashnyuk commented Mar 2, 2019 •
edited
Loading

As alternative implementation, I also thought about adding an additional constructor like

public ExecutorServiceProvider(int corePoolSize, int maxPoolSize, int queueCapacity, RejectedExecutionHandler handler) {

@skabashnyuk skabashnyuk requested a review from sleshchenko March 2, 2019 22:02
@skabashnyuk
Copy link
Contributor Author

ci-build

@sleshchenko
Copy link
Member

public ExecutorServiceProvider(int corePoolSize, int maxPoolSize, int queueCapacity, RejectedExecutionHandler handler) {

@skabashnyuk I like this way more, because for me ExecutorServiceProvider that implements RejectedExecutionHandler looks like a violation of single responsibility principle.

@skabashnyuk
fixup! Provide more informative error message in case of rejection on…
bf38f65 
… major websocket endpoint of JSON RPC stack

Signed-off-by: Sergii Kabashniuk <[email protected]>
@skabashnyuk
Copy link
Contributor Author

@sleshchenko ok

@skabashnyuk
Copy link
Contributor Author

ci-build

@skabashnyuk
Copy link
Contributor Author

ci-test

@skabashnyuk
fixup! fixup! Provide more informative error message in case of rejec…
701231c 
…tion on major websocket endpoint of JSON RPC stack

Signed-off-by: Sergii Kabashniuk <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12814
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor Author

ci-build

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12814
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk skabashnyuk merged commit 391c30e into master Mar 4, 2019
@skabashnyuk skabashnyuk deleted the jsonrpclogs branch March 4, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@riuvshin riuvshin Awaiting requested review from riuvshin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skabashnyuk @sleshchenko @che-bot