Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing 0 to Happy path tests screencast png's #14292

Merged
merged 12 commits into from
Aug 22, 2019
Merged

Add trailing 0 to Happy path tests screencast png's #14292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8e8ef37
Add trailing 0 to Happy path tests screencast png's
dmytro-ndp Aug 20, 2019
2fe7c0f
Make E2E Happy path tests screencast at PR check build
dmytro-ndp Aug 21, 2019
7e29b56
Add number at the start of screenshot file
dmytro-ndp Aug 21, 2019
7533025
[DON'T MERGE] PROVOKE FAILURE
dmytro-ndp Aug 21, 2019
05d360c
Work around default window size 800x600
dmytro-ndp Aug 21, 2019
c1f818d
Get rid of first screenshot with lower resolution 800*600
dmytro-ndp Aug 21, 2019
fb087f5
Restore HappyPath.spec.ts test
dmytro-ndp Aug 21, 2019
1ec0945
Work around abcense of test screenshots
dmytro-ndp Aug 22, 2019
a64e04d
Download chectl from next channel
dmytro-ndp Aug 22, 2019
2f31a15
[DO NOT MERGE] fail test to verify changes
dmytro-ndp Aug 22, 2019
013ff78
Fix screencast creation command in Jenkinsfile
dmytro-ndp Aug 22, 2019
17677ba
Restore HappyPath.spec.ts
dmytro-ndp Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions e2e/driver/CheReporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,6 @@ class CheReporter extends mocha.reporters.Spec {
}
});

runner.on('test end', async function (test: mocha.Test) {
Ohrimenko1988 marked this conversation as resolved.
Show resolved Hide resolved
if (!TestConstants.TS_SELENIUM_EXECUTION_SCREENCAST) {
return;
}

const currentMethodIndex: number = methodIndex;
let iterationIndex: number = 10000;

await screenCatcher.catchMethodScreen(test.title, currentMethodIndex, iterationIndex);
});

runner.on('end', async function (test: mocha.Test) {
// ensure that fired events done
await driver.get().sleep(5000);
Expand Down
9 changes: 6 additions & 3 deletions e2e/utils/ScreenCatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,15 @@ export class ScreenCatcher {

const date: Date = new Date();
const timeStamp: string = `(${date.getHours()}:${date.getMinutes()}:${date.getSeconds()}:${date.getMilliseconds()})`;
const screenshotPath: string = `${screenshotDir}/${screenshotIndex}-${methodName}-${timeStamp}.png`;

await this.catcheScreen(screenshotPath);
// add trailing 0 to have screenshots list normally sorted by name, e.g. 00000009, 00000010, ...
const formattedIndex: string = new Intl.NumberFormat('en-us', {minimumIntegerDigits: 8}).format(screenshotIndex).replace(/,/g, "");
const screenshotPath: string = `${screenshotDir}/${formattedIndex}-${methodName}-${timeStamp}.png`;

await this.catchScreen(screenshotPath);
}

async catcheScreen(screenshotPath: string) {
async catchScreen(screenshotPath: string) {
const screenshot: string = await this.driverHelper.getDriver().takeScreenshot();
const screenshotStream = fs.createWriteStream(screenshotPath);
screenshotStream.write(new Buffer(screenshot, 'base64'));
Expand Down