Various fixes after merging PR #16972 #17447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii Parfonov <[email protected]>
Signed-off-by: Vitalii Parfonov <[email protected]>
vparfonov
requested review from
amisevsk,
ibuziuk,
l0rd,
metlos,
nickboldt and
sleshchenko
as code owners
che-bot
added
status/code-review
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
sleshchenko
reviewed
Jul 21, 2020
.../main/java/org/eclipse/che/workspace/infrastructure/openshift/AsyncStorageModeValidator.java
Outdated
Show resolved
Hide resolved
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
metlos
approved these changes
Jul 21, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Parfonov [email protected]
What does this PR do?
Various fixes after merging PR #16972:
ServerServiceBuilderinAsyncStorageProvisionerUse ServerServiceBuilder in AsyncStorageProvisioner #17399AsyncStorageModeValidatorin this case they will be evaluated just once. Improvements in AsyncStorageModeValidator: move all possible checks to the constructor in this case they will be evaluated just once. #17420che.propertiesabout limitation for async storage