Parameterize Vagrantfile: Make Virtualbox Machine name configurable #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced CHE_VM_NAME environment variable to set the name of VirtualBox machine Signed-off-by: Andreas Scharf <[email protected]>
|
Can one of the admins verify this patch? |
|
lgtm, @zenobios - will you delete the branch that was created. |
tolusha
pushed a commit
that referenced
this pull request
Aug 4, 2016
…1966) - Introduced CHE_VM_NAME environment variable to set the name of VirtualBox machine Signed-off-by: Andreas Scharf <[email protected]>
ShimonBenYair
pushed a commit
to ShimonBenYair/che
that referenced
this pull request
Aug 4, 2016
…clipse-che#1966) - Introduced CHE_VM_NAME environment variable to set the name of VirtualBox machine Signed-off-by: Andreas Scharf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the changes described in #1965.
The behaviour if the Vagrantfile was not changed.