Enable PHP and JSON LS agents for all PHP stacks #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP developers work heavily with PHP files. The composer.json file is often used for managing dependencies. Thus, the agents for PHP and JSON language servers should be enabled by default for all PHP stacks.
|
Can one of the admins verify this patch? |
|
@TylerJewell or @slemeur need you confirm for this |
benoitf
added
kind/enhancement
vparfonov
approved these changes
Oct 18, 2016
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
PHP developers work heavily with PHP files. The composer.json file is often used for managing dependencies. Thus, the agents for PHP and JSON language servers should be enabled by default for all PHP stacks.
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the agents for the PHP and JSON language servers for all PHP stacks.
PHP developers work heavily with PHP files. The composer.json file is often used for managing dependencies. Thus, the agents for PHP and JSON language servers should be enabled by default for all PHP stacks.
What issues does this PR fix or reference?
PHP support #2590
Previous behavior
Agents for PHP and JSON language servers were not enabled for by default PHP stack.
New behavior
Agents for PHP and JSON language servers are enabled by default for all PHP stack.
PR type
Minor change checklist