CHE-2811 Launch all user commands by using bash if shell is not defined. #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example now that sh is default one, previous user commands may fail. If the commands are launched on sh, then /bin/sh will need to be defined as shell invoker Change-Id: I19e2065bfd9e6ee93a5d899cb67cd5b9ece76f62 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
severity/blocker
|
Build # 748 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/748/ to view the results. |
vparfonov
approved these changes
Oct 20, 2016
benoitf
removed
the
status/code-review
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…pse-che#2838) For example now that sh is default one, previous user commands may fail. If the commands are launched on sh, then /bin/sh will need to be defined as shell invoker Change-Id: I19e2065bfd9e6ee93a5d899cb67cd5b9ece76f62 Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For example now that sh is default one, previous user commands may fail. If the commands are required to be launched with sh, then /bin/sh will need to be defined as shell invoker but default is kept to bash
What issues does this PR fix or reference?
#2811
Previous behavior
it is now executing all user + internal commands with /bin/sh which may fail for user commands if user has a previous command that was using bash
so "all internal commands" use sh by default, user commands use bash
New behavior
Keep bash for user defined method unless the attribute "shell" is overrided to be an other interpreter
Change-Id: I19e2065bfd9e6ee93a5d899cb67cd5b9ece76f62
Signed-off-by: Florent BENOIT [email protected]