CHE-1787: Remove workspace id from websocket connection path to master #2907
Conversation
|
Build # 809 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/809/ to view the results. |
| getBus(workspaceId) { | ||
| var currentBus = this.sockets.get(workspaceId); | ||
| if (!currentBus) { | ||
| getBus() { |
There was a problem hiding this comment.
this kind of change needs to be applied on getRemoteBus as well
| @@ -23,7 +23,7 @@ | |||
| </context-param> | |||
| <context-param> | |||
| <param-name>org.eclipse.che.websocket.endpoint</param-name> | |||
| <param-value>/ws/{ws-id}</param-value> | |||
| <param-value>/ws</param-value> | |||
There was a problem hiding this comment.
could we have http redirect from /ws/ to /ws ?
for backward compliance for existing clients ?
There was a problem hiding this comment.
This is a network issue. This needs investigation.
|
Build # 817 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/817/ to view the results. |
vinokurig
changed the title
|
Build # 857 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/857/ to view the results. |
|
@benoitf Thank you, I will fix that. |
|
@vinokurig I've found another location, I will provide PR to fix it |
|
@benoitf ok, thanks |
What does this PR do?
Removes workspace id from websocket connection path to master.
What issues does this PR fix or reference?
#1787
Previous behavior
Separate web-socket connection was created for each workspase.
New behavior
All workspaces are using one web-socket connection.
@vparfonov @akurinnoy @ashumilova Please review