Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3369 Git history panel is not opened #3480

Merged
merged 2 commits into from
Dec 22, 2016
Merged

CHE-3369 Git history panel is not opened #3480

merged 2 commits into from
Dec 22, 2016

Conversation

vitaliy-guliy
Copy link
Contributor

Fixes appearing of Git history panel.

#3369

}

partStack.setActivePart(HistoryPresenter.this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be simplified to partStack.setActivePart(this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks.
This line was in the inner class and I forgot to remove prefix HistortyPresenter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@vitaliy-guliy vitaliy-guliy merged commit 1addec7 into master Dec 22, 2016
@vitaliy-guliy vitaliy-guliy deleted the CHE-3369 branch December 22, 2016 14:39
@codenvy-ci
Copy link

Build # 1431 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1431/ to view the results.

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* CHE-3369 Git history panel is not opened

* CHE-3369 Git history panel is not opened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants