[cli] switch to CLI to launch CHE inside chedir instead of the Che launcher #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which is not anymore maintained Change-Id: I742383ab47ad34a9d94a4e3ce823e802023062c2 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
kind/bug
benoitf
changed the title
slemeur
approved these changes
Jan 20, 2017
TylerJewell
approved these changes
Jan 20, 2017
TylerJewell
approved these changes
Jan 20, 2017
riuvshin
pushed a commit
that referenced
this pull request
Jan 20, 2017
… which is not anymore maintained (#3826) Change-Id: I742383ab47ad34a9d94a4e3ce823e802023062c2 Signed-off-by: Florent BENOIT <[email protected]>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1706/ |
benoitf
removed
the
status/code-review
akervern
pushed a commit
to akervern/che
that referenced
this pull request
Jan 23, 2017
… which is not anymore maintained (eclipse-che#3826) Change-Id: I742383ab47ad34a9d94a4e3ce823e802023062c2 Signed-off-by: Florent BENOIT <[email protected]>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
… which is not anymore maintained (eclipse-che#3826) Change-Id: I742383ab47ad34a9d94a4e3ce823e802023062c2 Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make that chedir uses the CLI to start Che instead of the eclipse che launcher which has been dropped
What issues does this PR fix or reference?
#3666
Previous behavior
Chedir was launching Che using che launcher but as it was not pushed we got old versions of che.
New behavior
Use of the latest cli to start che.
Tests written?
No
Docs updated?
no (internal stuff)
Changelog
Switch to CLI to launch CHE inside chedir instead of the Che launcher
Change-Id: I742383ab47ad34a9d94a4e3ce823e802023062c2
Signed-off-by: Florent BENOIT [email protected]