Simplify Dashboard build by relying on NPM run-script #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaud Kervern <[email protected]>
benoitf
approved these changes
Jan 20, 2017
benoitf
added
status/code-review
|
ci-build |
|
Can one of the admins verify this patch? |
akurinnoy
approved these changes
Jan 20, 2017
ashumilova
approved these changes
Jan 20, 2017
olexii4
approved these changes
Jan 20, 2017
benoitf
added a commit
to eclipse-che/che-docs
that referenced
this pull request
Jan 20, 2017
benoitf
added
status/pending-merge
and removed
status/code-review
|
@benoitf thanks a lot for your associated PR for docs. Added to release note |
benoitf
added a commit
that referenced
this pull request
Jan 20, 2017
With #3828 there is no need to install tools globally
|
(smiley_applause) ! |
slemeur
approved these changes
Jan 20, 2017
benoitf
added a commit
that referenced
this pull request
Jan 20, 2017
With #3828 there is no need to install tools globally
benoitf
added a commit
to eclipse-che/che-docs
that referenced
this pull request
Jan 20, 2017
|
@akervern thanks, it's now merged |
|
✨ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1707/ |
akervern
pushed a commit
to akervern/che
that referenced
this pull request
Jan 23, 2017
With eclipse-che#3828 there is no need to install tools globally
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Arnaud Kervern <[email protected]>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
With eclipse-che#3828 there is no need to install tools globally
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Arnaud Kervern <[email protected]>
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
With #3828 there is no need to install tools globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It simplify NPM dependencies install, and no more require to globally install
typings,bowerby relying on run-script env.What issues does this PR fix or reference?
Previous behavior
Required to install several NPM dependencies as global.
New behavior
Binary location are handled per NPM using local installation; it helps keeping the expected version installed defined in
package.jsonfile.Docs :
eclipse-che/che-docs#79
Release Note :
Changelog
Simplify Dashboard build by relying on NPM run-script