Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] bats / bats assertion support #3951

Merged
merged 2 commits into from
Jan 31, 2017
Merged

[cli] bats / bats assertion support #3951

merged 2 commits into from
Jan 31, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Jan 30, 2017

What does this PR do?

Include bats-support as part of the bats image
it allows to use assert commands for unit tests
https://github.com/ztombol/bats-assert#usage

Also install ncurses in the image to have tput tool for bats pretty formatting

What issues does this PR fix or reference?

none

Changelog and Release Note Information

Changelog

Adds pretty formatting in bats cli tests image and add bats-assert helper functions

Release Notes:
Adds pretty formatting in bats tests cli image and add bats-assert helper functions

Docs Pull Request

inner tools

- It allows to use smart helper like assert_equals, assert_output etc.

Change-Id: I0f539d9d087a0ab8ecff5de642ee6d0646e12a3b
Signed-off-by: Florent BENOIT <[email protected]>
Change-Id: I886af024aaca963329c0fd0982f073fa3380a624
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 30, 2017
@benoitf benoitf added this to the 5.2.0 milestone Jan 30, 2017
@benoitf benoitf self-assigned this Jan 30, 2017
@benoitf benoitf requested a review from TylerJewell January 30, 2017 17:21
@codenvy-ci
Copy link

Build # 1817 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1817/ to view the results.

@benoitf
Copy link
Contributor Author

benoitf commented Jan 30, 2017

@mlabuda FYI

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 30, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 31, 2017
@benoitf benoitf merged commit c8e1385 into master Jan 31, 2017
@benoitf benoitf deleted the bats-support branch January 31, 2017 09:19
@JamesDrummond JamesDrummond mentioned this pull request Feb 6, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants