Add validators for CAP inputs and Billing info inputs. #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashumilova
reviewed
Feb 27, 2017
| * @element | ||
| * | ||
| * @description | ||
| * `che-type-city` defines an attribute for input tag which allows to enter only digits. This directive should be used along with city-name-validator. |
There was a problem hiding this comment.
wrong description "enter only digits"
benoitf
approved these changes
Feb 27, 2017
| * @author Oleksii Kurinnyi | ||
| */ | ||
|
|
||
| export class CheTypeCity extends CheInputType{ |
There was a problem hiding this comment.
space between CheInputType and {
ashumilova
approved these changes
Feb 27, 2017
slemeur
approved these changes
Feb 27, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2049/ |
olexii4
reviewed
Feb 27, 2017
| @@ -17,6 +17,8 @@ import {CheReloadHref} from './reload-href/che-reload-href.directive'; | |||
| import {CheFormatOutput} from './format-output/che-format-output.directive'; | |||
| import {CheOnLongTouch} from './touch/che-on-long-touch.directive'; | |||
| import {CheOnRightClick} from './click/che-on-right-click.directive'; | |||
| import {CheTypeNumber} from "./input-type/input-number.directive"; | |||
| import {CheTypeCity} from "./input-type/input-city.directive"; | |||
olexii4
approved these changes
Feb 27, 2017
|
Build # 2053 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2053/ to view the results. |
ashumilova
approved these changes
Feb 28, 2017
added 2 commits
February 28, 2017 10:36
Added - custom input type directive to allow user to enter only digits; - custom input type directive to allow user to enter symbols used in city names; - directive to validate city names; Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
akurinnoy
force-pushed
the
billing-info-validation
branch
from
5f4af68 to
85bc215
Compare
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
) * Add validators for CAP inputs and Billing info inputs. Added - custom input type directive to allow user to enter only digits; - custom input type directive to allow user to enter symbols used in city names; - directive to validate city names; Signed-off-by: Oleksii Kurinnyi <[email protected]> * add tests Signed-off-by: Oleksii Kurinnyi <[email protected]>
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* Add validators for CAP inputs and Billing info inputs. Added - custom input type directive to allow user to enter only digits; - custom input type directive to allow user to enter symbols used in city names; - directive to validate city names; Signed-off-by: Oleksii Kurinnyi <[email protected]> * add tests Signed-off-by: Oleksii Kurinnyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
What issues does this PR fix or reference?
https://github.com/codenvy/saas/issues/150
https://github.com/codenvy/saas/issues/153
Changelog
Release Notes
N/A - bugfix
Docs PR
N/A - bugfix
Signed-off-by: Oleksii Kurinnyi [email protected]