Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4306 fix NPE in case of invalid java FQN #4654

Merged
merged 1 commit into from
Mar 31, 2017
+9 −1
Merged

#4306 fix NPE in case of invalid java FQN #4654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...lang-server/src/main/java/org/eclipse/che/plugin/java/server/rest/RefactoringService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.eclipse.jdt.core.ICompilationUnit;
import org.eclipse.jdt.core.IJavaElement;
import org.eclipse.jdt.core.IJavaProject;
import org.eclipse.jdt.core.IType;
import org.eclipse.jdt.core.JavaModelException;
import org.eclipse.jdt.internal.core.JavaModel;
import org.eclipse.jdt.internal.core.JavaModelManager;
Expand Down Expand Up @@ -89,7 +90,14 @@ public String createMoveRefactoring(CreateMoveRefactoring cmr) throws JavaModelE
if (javaElement.isPack()) {
return javaProject.findPackageFragment(new org.eclipse.core.runtime.Path(javaElement.getPath()));
} else {
return javaProject.findType(javaElement.getPath()).getCompilationUnit();

IType type = javaProject.findType(javaElement.getPath());

//in some cases client may send FQN that doesn't exist
if (type == null) {
throw new IllegalArgumentException("Can't find type: " + javaElement.getPath());
}
return type.getCompilationUnit();

}
} catch (JavaModelException e) {
Expand Down