Fix workspace storage path on Docker Cloud #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Signed-off-by: David Windell <[email protected]>
|
Please can this be in 5.10 O:-) |
|
Ok (although this is a bug fix for 5.x and doesn't change existing scenarios). For anyone who comes across this, you can use sed within the running che-server and then restart it to get workspace host paths working properly.
|
|
Sorry - I was leaving a comment for a different issue. This is a PR - up to Florent and other maintainers on when to merge it. This is super simple, so don't know why this wouldn't be included right away. |
benoitf
approved these changes
Apr 30, 2017
riuvshin
added
the
kind/bug
riuvshin
pushed a commit
that referenced
this pull request
May 26, 2017
This reverts commit dbfb74c.
riuvshin
pushed a commit
that referenced
this pull request
May 29, 2017
Signed-off-by: David Windell <[email protected]>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: David Windell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the problem with workspace data directories already fixed for some in #3324 but identified as not complete for all users in https://github.com/eclipse/che/blob/master/dockerfiles/che/entrypoint.sh#L310.
By using the cgroup file we can find the container's real ID without relying on the hostname (which can be changed with
--hostnameor by many clustering tools like Docker Cloud).Changelog
Fix workspace storage path where hostname does not match container name