Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-5350: change names of methods for WebSocket communication #5543

Merged
merged 2 commits into from
Jul 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_ARCHETYPE_CHANEL_OUTPUT;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_ARCHETYPE_CHANEL_SUBSCRIBE;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_CHANEL_SUBSCRIBE;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_SUBSCRIBE;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_PERCENT_METHOD;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_PERCENT_UNDEFINED_METHOD;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_START_STOP_METHOD;
Expand Down Expand Up @@ -68,7 +68,7 @@ private void subscribe(RequestTransmitter requestTransmitter) {

requestTransmitter.newRequest()
.endpointId(WS_AGENT_ENDPOINT)
.methodName(MAVEN_CHANEL_SUBSCRIBE)
.methodName(MAVEN_OUTPUT_SUBSCRIBE)
.noParams()
.sendAndSkipResult();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
import java.util.Set;

import static com.google.common.collect.Sets.newConcurrentHashSet;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_CHANEL_SUBSCRIBE;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_CHANEL_UNSUBSCRIBE;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_SUBSCRIBE;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_UNSUBSCRIBE;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_PERCENT_METHOD;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_PERCENT_UNDEFINED_METHOD;
import static org.eclipse.che.plugin.maven.shared.MavenAttributes.MAVEN_OUTPUT_START_STOP_METHOD;
Expand Down Expand Up @@ -75,13 +75,13 @@ private void unsubscribe() {
@Inject
private void configureHandlers(RequestHandlerConfigurator configurator) {
configurator.newConfiguration()
.methodName(MAVEN_CHANEL_SUBSCRIBE)
.methodName(MAVEN_OUTPUT_SUBSCRIBE)
.noParams()
.noResult()
.withConsumer(endpointIds::add);

configurator.newConfiguration()
.methodName(MAVEN_CHANEL_UNSUBSCRIBE)
.methodName(MAVEN_OUTPUT_UNSUBSCRIBE)
.noParams()
.noResult()
.withConsumer(endpointIds::remove);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public interface MavenAttributes {
String MAVEN_CHANEL_NAME = "maven:workspace";


String MAVEN_CHANEL_UNSUBSCRIBE = "mavenOutput/subscribe";
String MAVEN_CHANEL_SUBSCRIBE = "mavenOutput/unsubscribe";
String MAVEN_OUTPUT_UNSUBSCRIBE = "mavenOutput/unsubscribe";
String MAVEN_OUTPUT_SUBSCRIBE = "mavenOutput/subscribe";
String MAVEN_OUTPUT_TEXT_METHOD = "mavenOutput/text";
String MAVEN_OUTPUT_UPDATE_METHOD = "mavenOutput/update";
String MAVEN_OUTPUT_START_STOP_METHOD = "mavenOutput/start_stop";
Expand Down