Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a nonexistent file from the IDLC CMakeLists.txt #735

Conversation

clalancette
Copy link
Contributor

Otherwise, newer cmake (3.20) complains about it.

Signed-off-by: Chris Lalancette [email protected]

Here's a CI run of cyclonedds on ROS 2 infrastructure with this patch in place:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Otherwise, newer cmake (3.20) complains about it.

Signed-off-by: Chris Lalancette <[email protected]>
@k0ekk0ek
Copy link
Contributor

Great catch @clalancette! The hashid.c file is generated from some files in ddsrt now but I forgot to remove src/hashid.c. It's a surprise to me older versions let it slip. I'm happy to merge the PR, but before I do, may I request you sign the ECA? There's no need for a "Signed-off-by" footer anymore, but the signing the ECA is still mandatory even for small obvious fixes like this one. If you click the Details link next to the failed check, it should take you to the right form. Thanks.

@clalancette
Copy link
Contributor Author

If you click the Details link next to the failed check, it should take you to the right form. Thanks.

Thanks, I'm running it through internally. I'll "revalidate" once I've signed the agreement.

@k0ekk0ek
Copy link
Contributor

k0ekk0ek commented Apr 6, 2021

Closing this in favor of #737.

@k0ekk0ek k0ekk0ek closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants