Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare hashid.c file as GENERATED to solve cmake warning #756

Conversation

j-rivero
Copy link

@j-rivero j-rivero commented Apr 8, 2021

CMake does not consider the configured file as a file with extension in newer versions. While upstream fix it, I think there is no hurt on declaring it as GENERATED.

Tested: Build Status

close: #741

@k0ekk0ek
Copy link
Contributor

Thanks @j-rivero. However, I believe this issue is not currently not present anymore. Like I mentioned on #741 and #737, I believe the error came from the fact that I forgot to remove the src/hashid.c entry from the list of sources (I just copied it before). Are you still experiencing the issue with the current HEAD of master?

@j-rivero
Copy link
Author

Thanks Jeroen:

Are you still experiencing the issue with the current HEAD of master?

I just checked the nightly series and seems like the error is gone since April 8th. So you should be right, seems not a problem right now. Closing this.

@j-rivero j-rivero closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake Windows warning CMP0115
2 participants