feat: adds support for dcp v1.0 in default credential service client #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/4765_default_credential_service_dcp_v1_0
branch
from
5d17e17 to
5950baa
Compare
…ith backward compatibility option
wolf4ood
force-pushed
the
feat/4765_default_credential_service_dcp_v1_0
branch
from
5950baa to
5231809
Compare
wolf4ood
added
the
breaking-change
paullatzelsperger
approved these changes
Feb 3, 2025
| @@ -87,6 +94,10 @@ public class IdentityAndTrustExtension implements ServiceExtension { | |||
| private String issuerId; | |||
| @Setting(description = "The period of the JTI entry reaper thread in seconds", defaultValue = DEFAULT_CLEANUP_PERIOD_SECONDS + "", key = "edc.sql.store.jti.cleanup.period") | |||
| private long reaperCleanupPeriod; | |||
|
|
|||
| @Setting(description = "If set enable the dcp v0.8 namespace will be used", key = "edc.dcp.v08.enabled", required = false, defaultValue = "false") | |||
| private boolean enableDcpV08; | |||
There was a problem hiding this comment.
minor nit: i would call that property edc.dcp.v08.forced, since we're "forcing" (rather than "enabling) the v0.8 namespace.
jimmarino
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds support for dcp v1.0 in default credential service client with backward compatibility option.
This is marked as breaking change just notify the change of switching by default to dcp v1.0.
The dcp client can still support for now the v0.8 version by applying the setting
Why it does that
dcp v1.0 adoption
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #4765
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.