feat: make HashiCorp vault authentication extensible #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjaquensel
added
enhancement
ronjaquensel
force-pushed
the
vault-authentication-refactor
branch
from
1010cbf to
611b5ec
Compare
ndr-brt
reviewed
Feb 14, 2025
There was a problem hiding this comment.
I would put this in the spi folder, at the moment all the spis reside there (apart from some dsp ones, that I think they should be put there as well)
| * Copyright (c) 2022 Mercedes-Benz Tech Innovation GmbH | ||
| * Copyright (c) 2025 Cofinity-X |
|
|
||
| private Headers getHeaders() { | ||
| private Headers getHeaders(String token) { |
There was a problem hiding this comment.
given that tokenProvider is a class field, maybe it could be used internally in this method instead of having the token passed every time
| assertThat(tokenLookUpResult).isFailed(); | ||
| assertThat(tokenLookUpResult.getFailureDetail()).isEqualTo("Token look up failed with status 403"); | ||
| Assertions.assertThat(tokenLookUpResult.getFailureDetail()).isEqualTo("Token look up failed with status 403"); |
|
|
||
| @Provider(isDefault = true) | ||
| public HashicorpVaultTokenProvider tokenProvider() { | ||
| return new HashicorpVaultTokenProviderImpl(config.token()); |
There was a problem hiding this comment.
given that the token is only used in this extension maybe it could make sense to remove it from the Settings class and put it here as a single @Setting, it would also improve the way it's documented through autodoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Refactors the
vault-hashicorpmodule as outlined in this DR.Why it does that
To make vault authentication extensible and thus enable using different authentication methods.
Further notes
In addition to what's already mentioned in the DR:
HashicorpVaultTokenRenewService, which now contains the token look-up & renew methods previously located in the health service. I did not add them to theHashicorpVaultTokenRenewTaskdirectly, to keep a separation between the methods for renewing the token and the periodic task triggering the token renewal.vault-hashicorp-spi, which as of now contains only theHashicorpVaultTokenProviderinterface.Who will sponsor this feature?
me
Linked Issue(s)
Closes #4810
Closes #4751