Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta EE namespace transition #275

Merged
merged 1 commit into from
May 13, 2020

Conversation

jGauravGupta
Copy link
Member

Signed-off-by: Gaurav Gupta [email protected]

@rdebusscher rdebusscher self-requested a review May 13, 2020 07:22
@rdebusscher
Copy link
Member

Looks good.

There are a few other name changes required (like those for Jakarta Authorizaiton and Jakarta Authentication), but that can be done in another PR.

@arjantijms
Copy link
Contributor

Thanks @jGauravGupta !

@arjantijms arjantijms merged commit dfcc8df into eclipse-ee4j:master May 13, 2020
@keilw
Copy link
Member

keilw commented May 13, 2020

@arjantijms So this Jakarta spec will use "jakarta.security.enterprise", what about the other two raised e.g. by @thodorisbais?

@arjantijms
Copy link
Contributor

@keilw

This concerns the implementation. I wonder whether the artefact id should not just be "soteria" in stead of "jakarta.security.enterprise".

For the API though it should probably just be "jakarta.security". The "enterprise" part is unneeded. See here: https://github.com/eclipse-ee4j/security-api/blob/master/api/pom.xml#L30

@keilw
Copy link
Member

keilw commented May 13, 2020

Indeed, in the "impl" module "jakarta.security.enterprise" feels completely wrong, but I also spotted a few other problems, I'll raise a PR for that.
Regarding the API if we drop the "enterprise" that sounds fine, the question for all of them remains, if the Java packages of each API correspond with that groupId or not?

@arjantijms
Copy link
Contributor

It’s a small pattern that made a little sense for the RIs in Java EE:

Javax.foo and Javax.foo-api

But even there it wasn’t done consistently. Updated Java packages can be considered for Jakarta EE 10 yes. A bunch of people also asked to make Authentication and Authorization sub-specs of Security, we might look into that too then.

@keilw
Copy link
Member

keilw commented May 13, 2020

If the refactoring doesn't break anything later in Jakarta EE 10, we might do that later. Ideally the artifactId should only be changed once e.g. now after the specs got new names like "Authorization".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants