Initial version of the OpenId Connect implementation #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantijms
approved these changes
Feb 15, 2022
|
@rdebusscher I think we can merge this one in. The feedback items I had can be reworked afterwards. The only small thing in that the ECA fails since you did some commits using your rudy.de.busscher@****.fish email. |
|
@arjantijms So I guess the only thing I can do is create another PR to solve the ECA check failure. |
There's technically some git fu as well that allows you to edit previous commits in your branch, and then force push the result. See e.g. https://stackoverflow.com/questions/3042437/how-to-change-the-commit-author-for-one-specific-commit |
Signed-off-by: Rudy De Busscher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.