Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#583] @JsonbCreator uses PropertyNamingStrategy. #584

Merged
merged 1 commit into from
Feb 15, 2023
Merged

[#583] @JsonbCreator uses PropertyNamingStrategy. #584

merged 1 commit into from
Feb 15, 2023

Conversation

bmarwell
Copy link
Contributor

This might work, but I am not sure about what to pass in src/main/java16/org/eclipse/yasson/internal/ClassMultiReleaseExtension.java.

@bmarwell bmarwell mentioned this pull request Dec 10, 2022
Closed
@Verdent
Copy link
Member

Verdent commented Jan 6, 2023 •
edited
Loading

Watch out for those copyright failures :-) It should be 2023 now.

@bmarwell
Copy link
Contributor Author

bmarwell commented Jan 8, 2023

Watch out for those copyright failures :-) It should be 2023 now.

Actually the plugin does not check commit date, but author date. As I amended the previous commit, it must be 2022 according to the plugin. Unexpected, but that is what it takes to make the plugin happy. :)

@bmarwell bmarwell requested a review from Verdent January 8, 2023 15:30
@Verdent
Copy link
Member

Verdent commented Jan 13, 2023

Oh it seems you are having typo there :-)

@bmarwell
Copy link
Contributor Author

Sorry, broken keyboard (spilled soda over it) 😆

@jhanders34
Copy link
Member

Any more progress on this PR?

@Verdent
Copy link
Member

Verdent commented Feb 13, 2023

Oh, it seems it is failing on incorrectly separated imports. Otherwise, I think it is OK.

@bmarwell
Copy link
Contributor Author

Oh, it seems it is failing on incorrectly separated imports. Otherwise, I think it is OK.

Sigh, sorry! I am too used to checking in IDE config 😞 will fix this ASAP.

@Verdent
Copy link
Member

Verdent commented Feb 15, 2023

Perfect, thank you for this contribution @bmarwell

@Verdent Verdent merged commit 66bef09 into eclipse-ee4j:master Feb 15, 2023
@bmarwell bmarwell deleted the #583_JsonbCreator_property_naming_strategy branch March 11, 2023 11:30
@jamezp jamezp mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verdent Verdent Verdent approved these changes

Assignees

@bmarwell bmarwell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmarwell @Verdent @jhanders34