Eliminate Stream in #wrapInCommonSet #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elminate Stream creation in SerializationModelCreator#wrapInCommonSet as it was showing in during profiling. Signed-off-by: Philippe Marschall <[email protected]>
marschall
force-pushed
the
wrapInCommonSet-no-Stream
branch
from
34f5efb to
7361409
Compare
Degubi
approved these changes
Jul 4, 2023
|
Thanks for the review @Degubi The merge is still blocked as GitHub says a Review is still required. Can you tell me what the process looks like and how I should proceed? |
|
@marschall For me it says 'At least 1 approving review is required by reviewers with write access' |
Verdent
approved these changes
Oct 12, 2023
|
Thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elminate Stream creation in SerializationModelCreator#wrapInCommonSet as it was showing in during profiling.
SerializationModelCreator#wrapInCommonSetuses a single element stream to create aKeyWriterandNullSerializer. C2 is not able to optimize this away and the internal allocations of the stream API show up during profiling.