Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tool sometimes doesn't send ChangeBoundsAction #22

Closed
planger opened this issue Dec 23, 2019 · 1 comment · Fixed by #23
Closed

Move tool sometimes doesn't send ChangeBoundsAction #22

planger opened this issue Dec 23, 2019 · 1 comment · Fixed by #23
Assignees
@planger

Comments

@planger
Copy link
Member

planger commented Dec 23, 2019

If you drag an element for a bit back and forth the move tool doesn't send out a ChangeBoundsAction eventually. This seems to be fixed, when just checking whether a lastDragPosition exists and not if there actually is a positionDelta.
@planger planger self-assigned this Dec 23, 2019
@planger
Copy link
Member Author

planger commented Dec 23, 2019

Btw, this seems to cause the intermittent resets of positions after moving and receiving an update model that is also reported in eclipsesource/graphical-lsp#342.

planger added a commit that referenced this issue Dec 23, 2019
@planger
Fix mouse listener to always send out change bounds actions (#22)
c960c34 
With this change, we don't rely on the positionDelta for sending
out mouse ChangeBoundsActions but only check whether we started
dragging via lastDragPosition.

Resolves #22 and also fixes #21 while we're at it.
@planger planger mentioned this issue Dec 23, 2019
Merged
martin-fleck-at pushed a commit that referenced this issue Jan 8, 2020
@planger @martin-fleck-at
Fix mouse listener to always send out change bounds actions (#22)
b96925a 
With this change, we don't rely on the positionDelta for sending
out mouse ChangeBoundsActions but only check whether we started
dragging via lastDragPosition.

Resolves #22 and also fixes #21 while we're at it.
martin-fleck-at pushed a commit that referenced this issue Jan 8, 2020
@planger @martin-fleck-at
Fix mouse listener to always send out change bounds actions (#22) (#23)
4620882 
With this change, we don't rely on the positionDelta for sending
out mouse ChangeBoundsActions but only check whether we started
dragging via lastDragPosition.

Resolves #22 and also fixes #21 while we're at it.
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@planger @holkerveen
Fix mouse listener to always send out change bounds actions (eclipse-…
cfa2ee5 
…glsp#22) (eclipse-glsp#23)

With this change, we don't rely on the positionDelta for sending
out mouse ChangeBoundsActions but only check whether we started
dragging via lastDragPosition.

Resolves eclipse-glsp#22 and also fixes eclipse-glsp#21 while we're at it.
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@planger @holkerveen
Fix mouse listener to always send out change bounds actions (eclipse-…
4c8d50d 
…glsp#22) (eclipse-glsp#23)

With this change, we don't rely on the positionDelta for sending
out mouse ChangeBoundsActions but only check whether we started
dragging via lastDragPosition.

Resolves eclipse-glsp#22 and also fixes eclipse-glsp#21 while we're at it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@planger planger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mouse listener to always send out change bounds actions (#22) eclipse-glsp/glsp-client
1 participant
@planger