Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLSP-944 Remove usage of vscode-ws-jsonrpc #76

Merged
merged 2 commits into from
Mar 6, 2023
Merged

GLSP-944 Remove usage of vscode-ws-jsonrpc #76

merged 2 commits into from
Mar 6, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Mar 4, 2023 •
edited
Loading

@tortmayr tortmayr requested a review from martin-fleck-at March 4, 2023 10:53
martin-fleck-at
martin-fleck-at approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (as soon as the base changes are merged and the CI runs through! ;-) )

@tortmayr tortmayr merged commit 52353f6 into master Mar 6, 2023
@tortmayr tortmayr deleted the issues/944 branch August 28, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-fleck-at martin-fleck-at martin-fleck-at approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @martin-fleck-at