Fix jaeger RemoteControlledSampler not working in quarkus native images #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calohmn
added
Tracing
Quarkus
sophokles73
reviewed
May 21, 2021
...ces/META-INF/native-image/org.eclipse.hono/hono-adapter-base-quarkus/native-image.properties
Outdated
Show resolved
Hide resolved
sophokles73
reviewed
May 21, 2021
...rces/META-INF/native-image/org.eclipse.hono/hono-adapter-base-quarkus/reflection-config.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Carsten Lohmann <[email protected]>
calohmn
force-pushed
the
PR/jaeger_reflection_config
branch
from
49e6824 to
fe903ce
Compare
|
@calohmn how about putting this into a 1.8.1 as well? |
|
@sophokles73 Sure, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jaeger tracing currently doesn't work when using quarkus-native images and a jaeger sampling configuration that uses the sampling strategies defined in the Jaeger Collector component (i.e. using the RemoteControlledSampler).
This seems caused by the reflection used in conjunction with the
io.jaegertracing.internal.samplers.HttpSamplingManagerclass.There, a
SamplingStrategyResponseobject is deserialized from the JSON response using gson, which makes use of reflection to do so. That means that, at least with the currentquarkus-jaegercode, a reflection config has to be defined in places where the JaegerTracer is used (see also quarkusio/quarkus#10402 (comment)).This PR adds that.
Hope would be that quarkusio/quarkus#10402 gets solved in a way that doesn't make such a configuration necessary, so that this reflection config can be removed again with a quarkus update.
Relates to:
eclipse/packages#245
I've triggered a test build here also without the
jaegermaven profile. That causes some warnings (e.g.WARNING: Could not resolve io.jaegertracing.internal.samplers.http.OperationSamplingParameters for reflection configuration.), but the build succeeds.