Move the logic of MissingAnnotationAttributes to o.e.j.core.manipulation #335
+192
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
added a commit
to datho7561/eclipse.jdt.ls
that referenced
this pull request
Nov 18, 2022
Requires eclipse-jdt/eclipse.jdt.ui#335 Closes eclipse-jdtls#1806 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
migrate-annotation-attributes-proposal
branch
from
c0d032f to
9ba8835
Compare
|
|
rgrunber
reviewed
Dec 5, 2022
...n/core extension/org/eclipse/jdt/internal/corext/fix/MissingAnnotationAttributesFixCore.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
migrate-annotation-attributes-proposal
branch
from
9ba8835 to
8361ddd
Compare
rgrunber
approved these changes
Dec 6, 2022
Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
migrate-annotation-attributes-proposal
branch
from
8361ddd to
77adf22
Compare
datho7561
added a commit
to datho7561/eclipse.jdt.ls
that referenced
this pull request
Dec 7, 2022
Requires eclipse-jdt/eclipse.jdt.ui#335 Closes eclipse-jdtls#1806 Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
to datho7561/eclipse.jdt.ls
that referenced
this pull request
Dec 8, 2022
Requires eclipse-jdt/eclipse.jdt.ui#335 Closes eclipse-jdtls#1806 Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
to datho7561/eclipse.jdt.ls
that referenced
this pull request
Dec 9, 2022
Requires eclipse-jdt/eclipse.jdt.ui#335 Closes eclipse-jdtls#1806 Signed-off-by: David Thompson <[email protected]>
rgrunber
pushed a commit
to eclipse-jdtls/eclipse.jdt.ls
that referenced
this pull request
Dec 9, 2022
Requires eclipse-jdt/eclipse.jdt.ui#335 Closes #1806 Signed-off-by: David Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Moves all the text editing logic of the "add missing attributes to annotation" QuickFix to org.eclipse.jdt.core.manipulation so that it can be reused in jdt.ls.
How to test
Test that
MissingAnnotationAttributesFixCorecan be accessed from another project without needing to require any ui packages.Author checklist
Signed-off-by: David Thompson [email protected]