Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An exception occur when peek implementation #1007

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Apr 23, 2019

Fixes #1004

Signed-off-by: Snjezana Peco [email protected]

@snjeza snjeza requested review from gorkem and fbricon April 23, 2019 21:28
@fbricon
Copy link
Contributor

fbricon commented Apr 23, 2019

please change commit message to "Fix exception occuring when peeking at implementation"

Copy link
Contributor

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge once the commit message is fixed

@snjeza snjeza merged commit c7967e7 into eclipse-jdtls:master Apr 23, 2019
@snjeza snjeza deleted the issue-1004 branch April 23, 2019 22:00
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 1, 2019
Image extraction works, regular paths work too.

No tests.

Need to figure out how to get path of source jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 1, 2019
Image extraction works, regular paths work too.

No tests.

Need to figure out how to get path of source jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 8, 2019
Image extraction works, regular paths work too.

No tests.

Need to figure out how to get path of source jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 9, 2019
Image extraction works, regular paths work too.

No tests.

Need to figure out how to get path of source jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 14, 2019
Image extraction works, regular paths work too.

No tests.

Need to figure out how to get path of source jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 14, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 20, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 20, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 21, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Aug 22, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Sep 9, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Sep 16, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this pull request Sep 16, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes eclipse-jdtls#1007

Signed-off-by: Nikolas Komonen <[email protected]>
fbricon pushed a commit that referenced this pull request Sep 17, 2019
This PR solves the issue when the image linked in the javadoc points to a location inside the jar.

Fixes #1007

Signed-off-by: Nikolas Komonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An exception occur when peek implementation
2 participants