Add Code Action: Generate Constructors #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Peer UI PR: redhat-developer/vscode-java#921 |
|
test this please |
|
Could we combine the generate constructor from super class and from fields into one workflow, like in intellij? The idea is to 1st select the constructors from the parent you want generate, then select the fields to initialize. |
|
That would change the label of the source action to |
|
See IDEA workflow: |
fbricon
reviewed
May 14, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 14, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 14, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/lsp/JavaProtocolExtensions.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 14, 2019
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/ActionMessages.properties
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 14, 2019
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/ActionMessages.properties
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 14, 2019
....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/SourceAssistProcessor.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 14, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/ClientPreferences.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 14, 2019
....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/SourceAssistProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen
force-pushed
the
jinbo_constructor
branch
from
7a70139 to
9cc1150
Compare
testforstephen
changed the title
|
Nice, i like the suggested workflow. |
|
Merged as 43a78f7. I changed checkConstructorStatus => checkConstructorsStatus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Close #972