Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to support ChangeCorrectionProposal #1104

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

Eskibear
Copy link
Contributor

Fix #1103

Motivation

CUCorrectionProposal is dedicated for TextChange. This PR a prerequisite for composite changes like "create new type", which involves:

  • ResouceChange to create a file
  • TextChange to insert the content
  • A custom command (optional, if you want to tell client to switch focus onto the newly created file)

Changes

  • commit c21ec02
    • Change the copied proposals to extend ChangeCorrectionProposalCore and CUCorrectionProposalCore from jdt directly, and remove unnecessary classes.
    • Change Collection<CUCorrectionProposal> to Collection<ChangeCorrectionProposal> if necessary.
  • commit 3540f82 is trivial as the commit msg says.

@Eskibear
Copy link
Contributor Author

CI failed on the same case as #1095 (comment) , re-open to retrigger.

@fbricon
Copy link
Contributor

fbricon commented Jul 10, 2019

instead of closing/reopening the PR, you can add a comment test this please, that will trigger a new jenkins build

@fbricon
Copy link
Contributor

fbricon commented Jul 11, 2019

test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non-CUCorrectionProposal for CodeActions
2 participants