Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target range for quickfix:surround with try/multi-catch #1191

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Fix target range for quickfix:surround with try/multi-catch #1191

merged 3 commits into from
Sep 26, 2019

Conversation

Eskibear
Copy link
Contributor

@Eskibear
fix regression
069d73c 
Signed-off-by: Yan Zhang <[email protected]>
@fbricon
Copy link
Contributor

fbricon commented Sep 26, 2019

any chance you can add some unit test?

@Eskibear
Copy link
Contributor Author

sure

@Eskibear
Add unit tests
9493f8d 
Signed-off-by: Yan Zhang <[email protected]>
@fbricon fbricon merged commit 9e382ab into eclipse-jdtls:master Sep 26, 2019
@fbricon
Copy link
Contributor

fbricon commented Sep 26, 2019

Thanks @Eskibear

@Eskibear Eskibear deleted the multi-catch branch September 27, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong range of QuickFix: surround with try/multi-catch
2 participants
@Eskibear @fbricon