Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unrelated gradle projects during initialization #1265

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

testforstephen
Copy link
Contributor

Signed-off-by: Jinbo Wang [email protected]

Fix #1261

@testforstephen
Copy link
Contributor Author

In most cases, it's OK to delete those cached gradle projects not in current workspace.

One exceptional case is importing a sub module from a multi module gradle project.
For example, only open the sub module sagan-common from https://github.com/spring-io/sagan to current workspace, the buildship will still import other related modules to jdt too. When reloading the workspace, delete these implicitly referenced gradle projects during initialization didn't cause logic issue, because the following buildship synchronization job will add them back. In order to avoid the unnecessary delete operation, this PR adds logic to bypass this special case.

@fbricon fbricon merged commit 3ad831d into eclipse-jdtls:master Nov 13, 2019
@fbricon
Copy link
Contributor

fbricon commented Nov 13, 2019

thanks @testforstephen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build job reported the errors from unrelated gradle projects outside my workspace
2 participants