Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency to ICU #1362

Merged
merged 1 commit into from
Feb 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion org.eclipse.jdt.ls.core/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ Bundle-RequiredExecutionEnvironment: JavaSE-1.8
Bundle-Localization: plugin
Import-Package: org.osgi.framework;version="1.3.0"
Bundle-ActivationPolicy: lazy
Import-Package: com.ibm.icu.text
Require-Bundle: org.eclipse.core.runtime;bundle-version="3.12.0",
org.eclipse.core.resources,
org.eclipse.core.net,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*******************************************************************************/
package org.eclipse.jdt.ls.core.internal;

import com.ibm.icu.text.MessageFormat;
import java.text.MessageFormat;

/**
* Helper class to format message strings.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*******************************************************************************/
package org.eclipse.jdt.ls.core.internal.corext.refactoring.code;

import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
Expand Down Expand Up @@ -99,8 +100,6 @@
import org.eclipse.jface.text.IRegion;
import org.eclipse.ltk.core.refactoring.RefactoringStatus;

import com.ibm.icu.text.MessageFormat;

/* package */ class ExtractMethodAnalyzer extends CodeAnalyzer {

public static final int ERROR = -2;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.text.Collator;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Iterator;
Expand All @@ -35,8 +36,6 @@
import org.eclipse.text.edits.InsertEdit;
import org.eclipse.text.edits.TextEdit;

import com.ibm.icu.text.Collator;


public class NLSUtil {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*******************************************************************************/
package org.eclipse.jdt.ls.core.internal.corext.refactoring.rename;

import java.text.BreakIterator;
import java.util.ArrayList;
import java.util.List;

Expand All @@ -22,8 +23,6 @@
import org.eclipse.jdt.core.JavaCore;
import org.eclipse.jdt.ls.core.internal.text.JavaWordIterator;

import com.ibm.icu.text.BreakIterator;

/**
* This class contains methods for suggesting new names for variables or methods
* whose name consists at least partly of the name of their declaring type (or
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@
*******************************************************************************/
package org.eclipse.jdt.ls.core.internal.text;

import java.text.BreakIterator;
import java.text.CharacterIterator;

import org.eclipse.core.runtime.Assert;

import com.ibm.icu.text.BreakIterator;

/**
* A java break iterator. It returns all breaks, including before and after
* whitespace, and it returns all camel case breaks.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@
*******************************************************************************/
package org.eclipse.jdt.ls.core.internal.text;

import java.text.BreakIterator;
import java.text.CharacterIterator;

import org.eclipse.core.runtime.Assert;

import com.ibm.icu.text.BreakIterator;


/**
* Breaks java text into word starts, also stops at line start and end. No
Expand Down