Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompletionHandlerTest.testStarImports fails randomly #1411

Merged
merged 1 commit into from
Apr 27, 2020
Merged

CompletionHandlerTest.testStarImports fails randomly #1411

merged 1 commit into from
Apr 27, 2020

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Apr 16, 2020

Fixes #1409

Signed-off-by: Snjezana Peco [email protected]

@snjeza
Copy link
Contributor Author

snjeza commented Apr 16, 2020

test this please

4 similar comments
@snjeza
Copy link
Contributor Author

snjeza commented Apr 16, 2020

test this please

@snjeza
Copy link
Contributor Author

snjeza commented Apr 16, 2020

test this please

@snjeza
Copy link
Contributor Author

snjeza commented Apr 16, 2020

test this please

@snjeza
Copy link
Contributor Author

snjeza commented Apr 16, 2020

test this please

@snjeza snjeza requested review from fbricon and gorkem April 16, 2020 15:39
@snjeza snjeza force-pushed the issue-1409 branch 2 times, most recently from ce80a22 to 04f9edf Compare April 17, 2020 18:51
@snjeza
Copy link
Contributor Author

snjeza commented Apr 17, 2020

test this please

@snjeza snjeza changed the title [WIP] CompletionHandlerTest.testStarImports fails randomly CompletionHandlerTest.testStarImports fails randomly Apr 17, 2020
@snjeza
Copy link
Contributor Author

snjeza commented Apr 26, 2020

@fbricon I have updated the PR.

fbricon
fbricon reviewed Apr 26, 2020
View reviewed changes
Copy link
Contributor

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now I want to know why is this the only completion test requiring a timeout increase. That's super odd

@snjeza
Copy link
Contributor Author

snjeza commented Apr 26, 2020

So, now I want to know why is this the only completion test requiring a timeout increase. That's super odd

The OrganizeImportOperation operation is pretty slow.

@fbricon fbricon merged commit a5d7452 into eclipse-jdtls:master Apr 27, 2020
@fbricon
Copy link
Contributor

fbricon commented Apr 27, 2020

@snjeza ok thanks

@snjeza snjeza mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

@gorkem gorkem Awaiting requested review from gorkem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CompletionHandlerTest.testStarImports fails randomly
2 participants
@snjeza @fbricon