Add semantic token type 'constructor' #1514
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a more specific token type for constructors, called
constructor
, which will allow constructors to be colored differently from methods, if desired. I could submit a PR to vscode-java, similar to redhat-developer/vscode-java#1540, which would allowmethod
to be the supertype ofconstructor
, in order to avoid breaking current color themes.Unfortunately, I encountered a problem whilst implementing this: when a VS Code client receives a
constructor
token, the semantic highlighting completely breaks for that file. After some debugging, I found out that it was a bug in VS Code, so I have submitted an issue (microsoft/vscode#103104) about that. Until that gets fixed, this PR is not ready to be merged.